Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44189 )
Change subject: mb/google/dedede: Add a board specific reset
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44189/5/src/mainboard/google/dedede...
File src/mainboard/google/dedede/mainboard.c:
https://review.coreboot.org/c/coreboot/+/44189/5/src/mainboard/google/dedede...
PS5, Line 15: TODO
I think a bug should be filed instead of a TODO in the code if there is still more needed here that […]
Yes, one of the required changes to cache tpm firmware version is going through the review simultaneously. Once that change gets merged, the last CL in this stack can be rebased on top of that.
Even otherwise, this change works with both old and new cr50 firmware versions.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1f7271130e0b4b68c7f0917ecc4eadba1486206
Gerrit-Change-Number: 44189
Gerrit-PatchSet: 5
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Henry Sun
henrysun@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Thu, 13 Aug 2020 21:34:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment