Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40245 )
Change subject: mainboard/volteer: Update Aux settings for Port 0 ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40245/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/40245/5/src/mainboard/google/voltee... PS5, Line 128: 0x090E000A
Yeah this makes sense I'll work on a better implementation that is more easily readable
I will be pushing the non hard coded method as a separate patch to avoid issues on getting this merged so AUX flipping works on Volteer
https://review.coreboot.org/c/coreboot/+/40245/5/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40245/5/src/mainboard/google/voltee... PS5, Line 242: /* E22 : DDPA_CTRLCLK ==> USB_C1_AUXP_DC: Retimer FW drives this pin */ : PAD_NC(GPP_E22, NONE), : /* E23 : DDPA_CTRLDATA ==> USB_C1_AUXN_DC: Retimer FW drives this pin */ : PAD_NC(GPP_E23, NONE),
If these are set to NF6 they will be SOC controlled instead of Retimer controller. […]
Ack