Attention is currently required from: Jakub Czapiga, Julius Werner, Nico Huber, Philipp Hug, ron minnich.
Hello Jakub Czapiga, Julius Werner, Philipp Hug, build bot (Jenkins), ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/79907?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins)
Change subject: [RFC] region: Hide struct region members ......................................................................
[RFC] region: Hide struct region members
We cannot make `struct region` opaque for several reasons (size needs to be known for local objects, a lot of inline API functions, ...). However, we still want to encourage using the high-level region API instead of directly accessing and manipulating the struct members. This patch tries to achieve this by renaming the struct members. Only if REGION_INTERNAL_STRUCTURES is defined before including <region.h>, the usual member names are used.
Change-Id: I713be9cf0bab4c2e21113b55e7229ab50f06c6cf Signed-off-by: Nico Huber nico.h@gmx.de --- M src/arch/arm/fit_payload.c M src/arch/arm64/fit_payload.c M src/arch/riscv/fit_payload.c M src/commonlib/include/commonlib/region.h M src/commonlib/region.c M src/lib/fit_payload.c M tests/commonlib/region-test.c M tests/lib/cbfs-lookup-test.c M tests/lib/fmap-test.c 9 files changed, 26 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/79907/2