build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35490 )
Change subject: drivers/i2c/at24rf08c: Cache devices associated with this driver ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35490/1/src/drivers/i2c/at24rf08c/l... File src/drivers/i2c/at24rf08c/lenovo.h:
https://review.coreboot.org/c/coreboot/+/35490/1/src/drivers/i2c/at24rf08c/l... PS1, Line 21: void lenovo_serials_register_bank(struct device *); function definition argument 'struct device *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/35490/1/src/drivers/i2c/at24rf08c/l... File src/drivers/i2c/at24rf08c/lenovo_serials.c:
https://review.coreboot.org/c/coreboot/+/35490/1/src/drivers/i2c/at24rf08c/l... PS1, Line 31: if (0x54 > dev->path.i2c.device || dev->path.i2c.device > 0x57) Comparisons should place the constant on the right side of the test