23 May
2020
23 May
'20
1:17 p.m.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38978 )
Change subject: [WIP] mainboard: Add Acer ES1-572 ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... File src/mainboard/acer/es1-572/gpio.h:
https://review.coreboot.org/c/coreboot/+/38978/4/src/mainboard/acer/es1-572/... PS4, Line 105: _PAD_CFG_STRUCT(GPP_A19,
why not use PAD_CFG_NC for nc pads?
We had a talk about this on IRC. This is done to have a defined state to prevent floating. This could be shortened as NC_PAD(GPP_A19, 20K_PD) instead
--
To view, visit https://review.coreboot.org/c/coreboot/+/38978
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id98788a2c5e54f70fd1cacbd70d636f5e63b2619
Gerrit-Change-Number: 38978
Gerrit-PatchSet: 5
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Comment-Date: Sat, 23 May 2020 11:17:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment