[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Update fsp params for Jasper Lake

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38461 )

Change subject: soc/intel/tigerlake: Update fsp params for Jasper Lake
......................................................................

Patch Set 5:

(3 comments)

https://review.coreboot.org/c/coreboot/+/38461/5/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params_jsl.c:

https://review.coreboot.org/c/coreboot/+/38461/5/src/soc/intel/tigerlake/fsp... 
PS5, Line 72: enable/disable devices
Nit: I am not seeing any enable/disable device actions besides parsing the devicetree. May be the comment needs some update?

https://review.coreboot.org/c/coreboot/+/38461/5/src/soc/intel/tigerlake/fsp... 
PS5, Line 86: MP PPI
Just curious: What is MP PPI?

https://review.coreboot.org/c/coreboot/+/38461/5/src/soc/intel/tigerlake/fsp... 
PS5, Line 132: 	if (!dev)
Nit: Use "{" because else block has braces. Just to improve the readability. Same comment for line 143.