Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39710 )
Change subject: soc/intel/tigerlake: Implement CHIPSET_LOCKDOWN
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39710/10//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39710/10//COMMIT_MSG@11
PS10, Line 11: to
for?
https://review.coreboot.org/c/coreboot/+/39710/10/src/soc/intel/tigerlake/fs...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/39710/10/src/soc/intel/tigerlake/fs...
PS10, Line 116: PchUnlockGpioPads
Unrelated, it is very confusing to have *Unlock* here and not consistently *Lock*.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I63cec8a718285f424914e426d0399ed821588dfd
Gerrit-Change-Number: 39710
Gerrit-PatchSet: 10
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Francois Toguo Fotso
francois.toguo.fotso@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 Apr 2020 15:20:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment