Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37212 )
Change subject: arch/x86/exit_car.S: Make sure _cbmem_top_ptr hits dram
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37212/7/src/arch/x86/exit_car.S
File src/arch/x86/exit_car.S:
https://review.coreboot.org/c/coreboot/+/37212/7/src/arch/x86/exit_car.S@35
PS7, Line 35: clflush
Use wbinv if clflush isn't supported?
I think the goal is to keep nothing left from the CAR environment. wbinv might in some cases write to RAM (corrupting RAM on S3 resume) or to 'nothing' which might have some undesirable behaviour.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37212
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37681ee1f1d2ae5f9dd824b5baf7b23b2883b1dc
Gerrit-Change-Number: 37212
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 08 Aug 2020 08:27:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment