Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35299 )
Change subject: soc/intel/cannonlake: Allow coreboot to handle SPI lockdown
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35299/2/src/soc/intel/cannonlake/fs...
File src/soc/intel/cannonlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/35299/2/src/soc/intel/cannonlake/fs...
PS2, Line 421: #
Is the reason for using the preprocessor, that other SOC have different UPD?
yes you got it right. Other SOCs like CNL, CFL, WHL doesn't have FSP UPD to skip SPI lockdown options and those products are in production now so code changes are not feasible hence added the support in CML and due to compilation issue guarding it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35299
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7a6b9859e058b9f1ec1bd45d2c388c02b8ac18c
Gerrit-Change-Number: 35299
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 09 Sep 2019 06:13:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment