Piotr Kleinschmidt has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42097 )
Change subject: mb/pcengines/apu2/mptable.c: fix invalid MP table and IRQ table ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42097/5/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/amd_pci_int_defs.h:
https://review.coreboot.org/c/coreboot/+/42097/5/src/southbridge/amd/pi/huds... PS5, Line 43: #define PIRQ_OHCI1 0x30 /* USB OHCI 12h.0 */ : #define PIRQ_EHCI1 0x31 /* USB EHCI 12h.2 */ : #define PIRQ_OHCI2 0x32 /* USB OHCI 13h.0 */ : #define PIRQ_EHCI2 0x33 /* USB EHCI 13h.2 */ : #define PIRQ_OHCI3 0x34 /* USB OHCI 16h.0 */ : #define PIRQ_EHCI3 0x35 /* USB EHCI 16h.2 */ : #define PIRQ_OHCI4 0x36 /* USB OHCI 14h.5 */ I'm not quite sure about those changes as it is not board specific. However, if we want to do away with OHCI references it should be done this way, shouldn't it?
https://review.coreboot.org/c/coreboot/+/42097/5/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/pci_devs.h:
https://review.coreboot.org/c/coreboot/+/42097/5/src/southbridge/amd/pi/huds... PS5, Line 27: /* OHCI */ : #define OHCI1_DEV 0x12 : #define OHCI1_FUNC 0 : #define OHCI2_DEV 0x13 : #define OHCI2_FUNC 0 : #define OHCI3_DEV 0x16 : #define OHCI3_FUNC 0 : #define OHCI4_DEV 0x14 : #define OHCI4_FUNC 5 : #define OHCI_DEVID 0x7807 : #define OHCI1_DEVFN PCI_DEVFN(OHCI1_DEV,OHCI1_FUNC) : #define OHCI2_DEVFN PCI_DEVFN(OHCI2_DEV,OHCI2_FUNC) : #define OHCI3_DEVFN PCI_DEVFN(OHCI3_DEV,OHCI3_FUNC) : #define OHCI4_DEVFN PCI_DEVFN(OHCI4_DEV,OHCI4_FUNC) As I mentioned in the other comment, I'm not sure if it is right to get rid of OHCI at all. However, if we want to refer properly, then at least EHCIn_FUNC must be redefine to 0 and it would collide with OHCIn_FUNC. Is there a better way to avoid this?