build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39111 )
Change subject: soc/intel/tigerlake: Add Jasper lake GPIO support
......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39111/6/src/soc/intel/tigerlake/gpi...
File src/soc/intel/tigerlake/gpio_jsl.c:
https://review.coreboot.org/c/coreboot/+/39111/6/src/soc/intel/tigerlake/gpi...
PS6, Line 105: },
trailing whitespace
https://review.coreboot.org/c/coreboot/+/39111/6/src/soc/intel/tigerlake/inc...
File src/soc/intel/tigerlake/include/soc/gpio_soc_defs_jsl.h:
https://review.coreboot.org/c/coreboot/+/39111/6/src/soc/intel/tigerlake/inc...
PS6, Line 25: #define GPP_F 0x9
please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39111/6/src/soc/intel/tigerlake/inc...
PS6, Line 26: #define GPP_G 0x2
please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39111/6/src/soc/intel/tigerlake/inc...
PS6, Line 28: #define GPP_A 0x0
please, no space before tabs
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39111
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae4e694ecb30658e43c5ed99e5436579fd7d2ed2
Gerrit-Change-Number: 39111
Gerrit-PatchSet: 6
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Sooraj Govindan
sooraj.govindan@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Feb 2020 15:58:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment