Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/29516 )
Change subject: payloads/external/Linuxboot: support u-root versions
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29516/2/payloads/external/LinuxBoot/targets/...
File payloads/external/LinuxBoot/targets/u-root.mk:
https://review.coreboot.org/#/c/29516/2/payloads/external/LinuxBoot/targets/...
PS2, Line 48: ifneq ($(CONFIG_LINUXBOOT_UROOT_VERSION), master)
why don't checkout master ? […]
How is it suppose to work if the target directory isn't a git repo any more ? Does go get set up a local git repo for you ?
--
To view, visit
https://review.coreboot.org/29516
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65e1ccf0319809f7fab23142b31882e9928a5ec2
Gerrit-Change-Number: 29516
Gerrit-PatchSet: 2
Gerrit-Owner: Jens Drenhaus
jens.drenhaus@9elements.com
Gerrit-Reviewer: Marcello Sylvester Bauer
marcello.bauer@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 06 Nov 2018 18:06:27 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No