Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45635 )
Change subject: vendorcode/google: add CHROMEOS_DRAM_PART_NUMBER_IN_CBI Kconfig option ......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45635/17/src/vendorcode/google/chro... File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/45635/17/src/vendorcode/google/chro... PS17, Line 107: y
This should not be set to 'y' by default. We should let the mainboard select it only if required.
Isn't storing DRAM part number in the CBI a POR for chromeos devices? If so, why would we not want to default to y, and just let any chromebooks that go against the norm of storing dram part number in CBI to override the behavior by setting it to "n" in their Kconfig?
I set it to "n" currently to avoid compile issues that require changes that don't really belong in this CL, but as I stated in the checkin comment, my intent is to change it to "y" in a subsequent (next) CL that uses this new Kconfig option to use the common version of mainboard_get_dram_part_num. Is this not the right approach / is storing part num in CBI not standard practice for chromebooks going forward?