build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48163 )
Change subject: lenovo/g505s: add the PIRQ routing table ......................................................................
Patch Set 7:
(15 comments)
File src/mainboard/lenovo/g505s/irq_tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/ea1e098e_b4d90217 PS7, Line 22: /* bus, dev | fn, {{link, bitmap}, {link, bitmap}, {link, bitmap}, {link, bitmap} }, slot, rfu */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/69ce8105_ca4b16e4 PS7, Line 24: {0x00, (0x00 << 3) | 0x2, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/eaa3fb0e_59b13254 PS7, Line 27: {0x00, (0x01 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/9dc43934_f8500355 PS7, Line 29: {0x00, (0x02 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/c9a490be_b22b6a0b PS7, Line 31: {0x00, (0x04 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/34f52dc2_aeb275cc PS7, Line 33: {0x00, (0x05 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/02aee5ff_6f3d5242 PS7, Line 35: {0x00, (0x10 << 3) | 0x0, {{0x03, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/e72b7b6b_2c1f7f0e PS7, Line 37: {0x00, (0x11 << 3) | 0x0, {{0x04, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/d4b08fd5_76854cce PS7, Line 40: {0x00, (0x12 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/e183b28a_c237236d PS7, Line 43: {0x00, (0x13 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/9c1d7585_be07d129 PS7, Line 46: {0x00, (0x16 << 3) | 0x0, {{0x03, 0xdc90}, {0x02, 0xdc90}, {0x00, 0x0000}, {0x00, 0x0000} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/7c564e96_7ea0ebea PS7, Line 49: {0x00, (0x14 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x0, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/3722a438_37b36fe2 PS7, Line 51: {0x01, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x1, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/2f0a634b_6634d135 PS7, Line 53: {0x02, (0x00 << 3) | 0x0, {{0x01, 0xdc90}, {0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90} }, 0x2, 0x0}, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117707): https://review.coreboot.org/c/coreboot/+/48163/comment/9c8b0bda_bd869a88 PS7, Line 55: {0x03, (0x00 << 3) | 0x0, {{0x02, 0xdc90}, {0x03, 0xdc90}, {0x04, 0xdc90}, {0x01, 0xdc90} }, 0x3, 0x0} line over 96 characters