Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38548 )
Change subject: soc/intel: Add Intel Xeon Scalable Processor support ......................................................................
Patch Set 40:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38548/40/src/soc/intel/xeon_sp/Kcon... File src/soc/intel/xeon_sp/Kconfig:
https://review.coreboot.org/c/coreboot/+/38548/40/src/soc/intel/xeon_sp/Kcon... PS40, Line 30: select ARCH_VERSTAGE_X86_32 why do we need verstage?
https://review.coreboot.org/c/coreboot/+/38548/40/src/soc/intel/xeon_sp/Kcon... PS40, Line 139: config CPU_BCLK_MHZ : int : default 100 I am not sure this is accurate or applies. Is it used in the patch?