Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43760 )
Change subject: mb/clevo/kbl-u: Add Clevo N240BU as variant
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43760/15/src/mainboard/clevo/kbl-u/...
File src/mainboard/clevo/kbl-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/43760/15/src/mainboard/clevo/kbl-u/...
PS15, Line 48: default 0x500000 if BOARD_CLEVO_N240BU
Starting with no configuration, selecting the variant, the 5 MB value is not chosen. I guess, this line needs to be before the other default line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43760
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57dc2db78c66dd93642f41d10343d1be05fb9f17
Gerrit-Change-Number: 43760
Gerrit-PatchSet: 15
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 28 Jul 2020 07:00:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment