HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44507 )
Change subject: soc/intel/apl: Add ACPI for SMBus control
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44507/9/src/soc/intel/apollolake/ac...
File src/soc/intel/apollolake/acpi/smbus.asl:
https://review.coreboot.org/c/coreboot/+/44507/9/src/soc/intel/apollolake/ac...
PS9, Line 65: One
I would: […]
not sure here ...
looks like the ASL+ compiler will use Zero and One (optimization ...?)
and it convert decimals to hex :)
maybe we need a rule for ("Zero" and "One")
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44507
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3846266d3155bbe831123fef4751748ff0e00511
Gerrit-Change-Number: 44507
Gerrit-PatchSet: 9
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 27 Sep 2020 14:40:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment