Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Felix Held, Fred Reitberger, Jakub Czapiga, Jason Glenesk, Kapil Porwal, Matt DeVillier, Nicholas Chin, Nick Vaccaro, Pranava Y N, Subrata Banik, Tarun.
Hello Dinesh Gehlot, Eran Mitrani, Felix Held, Fred Reitberger, Jakub Czapiga, Jason Glenesk, Jayvik Desai, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Pranava Y N, Subrata Banik, Tarun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84677?usp=email
to look at the new patch set (#8).
Change subject: soc/*: Explicitly include static.h for DEV_PTR ......................................................................
soc/*: Explicitly include static.h for DEV_PTR
As per commit 05a13e7ed9b9 ("sconfig: Move (WEAK_)DEV_PTR from device.h to static.h"), sources that require access to devicetree static devices should directly include static.h. This allows static.h to be removed from device.h, eliminating unnecessary dependencies on the devicetree for objects that only need the device types and function declarations.
The DEV_PTR macro resolves to names declared in static_devices.h, which is then included in static.h, so include the header whenever the macro is used.
Change-Id: Ie281e9a9c015b19bfc96b83021a6e3afd98abcc3 Signed-off-by: Nicholas Chin nic.c3.14@gmail.com --- M src/soc/amd/cezanne/include/soc/xhci.h M src/soc/amd/common/pi/agesawrapper.c M src/soc/amd/mendocino/include/soc/xhci.h M src/soc/amd/mendocino/xhci.c M src/soc/amd/phoenix/include/soc/xhci.h M src/soc/amd/stoneyridge/BiosCallOuts.c M src/soc/amd/stoneyridge/fch.c M src/soc/amd/stoneyridge/fch_agesa.c M src/soc/amd/stoneyridge/northbridge.c M src/soc/intel/alderlake/retimer.c M src/soc/intel/meteorlake/retimer.c M src/soc/intel/pantherlake/retimer.c M src/soc/intel/tigerlake/retimer.c 13 files changed, 14 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/84677/8