Attention is currently required from: Avi Uday, Intel coreboot Reviewers, Nick Vaccaro, Sowmya Aralguppe, Usha P, Varun Upadhyay.
Appukuttan V K has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/87262?usp=email )
Change subject: soc/intel: Add Wildcat Lake CPU and PCIE device IDs
......................................................................
Patch Set 9:
(2 comments)
File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/87262/comment/1071b025_195d1c66?usp... :
PS8, Line 4804:
I see that some devices like these ones have not been added to the corresponding pci_device_ids[]. […]
Thankyou. Removed other CSE function device IDs, we are using only function 0.
File src/soc/intel/common/block/uart/uart.c:
https://review.coreboot.org/c/coreboot/+/87262/comment/4946bfbf_39310102?usp... :
PS8, Line 362: static const unsigned short pci_device_ids[] = {
Should the UART devices not be added here too?
Done. Missed to add this earlier.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87262?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4bc7a8ea898ee30d565a95b9f85d6f19886bcffb
Gerrit-Change-Number: 87262
Gerrit-PatchSet: 9
Gerrit-Owner: Appukuttan V K
appukuttan.vk@intel.com
Gerrit-Reviewer: Avi Uday
aviuday@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-CC: Sanju Jose Thottan
sanjujose.thottan@intel.com
Gerrit-Attention: Avi Uday
aviuday@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Attention: Varun Upadhyay
varun.upadhyay@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Mon, 21 Apr 2025 06:31:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Avi Uday
aviuday@google.com