Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38992 )
Change subject: soc/intel/icelake: Skip FSP-S IGD related UPD override ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38992/1/src/soc/intel/icelake/fsp_p... File src/soc/intel/icelake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/38992/1/src/soc/intel/icelake/fsp_p... PS1, Line 97: params->GtFreqMax = 2; : params->CdClock = 3;
did u look at https://review.coreboot.org/c/coreboot/+/38992/3/src/soc/intel/icelake/fsp_p.... […]
finally we can get rid of this if condition and additional GtFreq and CDClk override
https://review.coreboot.org/c/coreboot/+/38992/4/src/soc/intel/icelake/fsp_p... File src/soc/intel/icelake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/38992/4/src/soc/intel/icelake/fsp_p... PS4, Line 97: perform IGD initialization
yes
Ack