Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44039 )
Change subject: mb/google/volteer: Use device aliases ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44039/13/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/44039/13/src/mainboard/google/volte... PS13, Line 464: on This got dropped when moving to aliases. I don't see this being kept on in baseboard/devicetree or variant/overridetree.
https://review.coreboot.org/c/coreboot/+/44039/13/src/mainboard/google/volte... PS13, Line 475: on Same here.
https://review.coreboot.org/c/coreboot/+/44039/13/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/malefor/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44039/13/src/mainboard/google/volte... PS13, Line 66: i2c3 This should be i2c2.