Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42295 )
Change subject: soc/intel/tigerlake: Update TCSS for SW CM support ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42295/6/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/tcss.asl:
https://review.coreboot.org/c/coreboot/+/42295/6/src/soc/intel/tigerlake/acp... PS6, Line 138: Method (_OSC, 4, Serialized) : { : /* : * Operating System Capabilities for USB4 : * Arg0: UUID = {23A0D13A-26AB-486C-9C5F-0FFA525A575A} : * Arg1: Revision ID = 1 : * Arg2: Count of entries (DWORD) in Arg3 (Integer): 3 : * Arg3: DWORD capabilities buffer: : * First DWORD: The standard definition bits are used to return errors. : * Second DWORD: OSPM support field for USB4, bits [31:0] reserved. : * Third DWORD: OSPM control field for USB4. : * bit 0: USB tunneling : * bit 1: DisplayPort tunneling : * bit 2: PCIe tunneling : * bit 3: Inter-domain USB4 internet protocol : * bit 31:4: reserved : * Return: The platform acknowledges the capabilities buffer by returning : * a buffer of DWORD of the same length. Masked/Cleared bits in the : * control field indicate that the platform does not permit OSPM : * control of the respectively capabilities or features. : */ : Name (CTRL, 0) /* Control field value */ : If (Arg0 == ToUUID("23A0D13A-26AB-486C-9C5F-0FFA525A575A")) { : CreateDWordField(Arg3, 0, CDW1) : CreateDWordField(Arg3, 2, CDW3) : CTRL = CDW3 : : If (Arg1 != REVISION_ID) { : CDW1 |= UNRECOGNIZED_REVISION : } : CTRL |= USB_TUNNELING | DISPLAY_PORT_TUNNELING | PCIE_TUNNELING | : INTER_DOMAIN_USB4_INTERNET_PROTOCOL : CDW3 = CTRL : Return (Arg3) : } Else { : CDW1 |= UNRECOGNIZED_UUID : Return (Arg3) : } : } Thank you, this is much cleaner now 😊 but all of this should be indented with tabs, not spaces.
https://review.coreboot.org/c/coreboot/+/42295/6/src/soc/intel/tigerlake/acp... PS6, Line 306: 0x7090 Maybe another symbolic constant? MCHBAR_TCSS_DEVEN_OFFSET ?