Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40612 )
Change subject: soc/intel/jasperlake: Enable end of post support
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40612/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/40612/1//COMMIT_MSG@7
PS1, Line 7: Enable end of post support
In what phase?
https://review.coreboot.org/c/coreboot/+/40612/1/src/soc/intel/jasperlake/fs...
File src/soc/intel/jasperlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/40612/1/src/soc/intel/jasperlake/fs...
PS1, Line 101: 0x01
So, what is the difference between sending EOP in PEI v/s DXE? I believe this is setting it to happen in PEI?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40612
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie21dcfc84d331f036090d01ea3e3925b81eea902
Gerrit-Change-Number: 40612
Gerrit-PatchSet: 1
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 27 Apr 2020 05:30:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment