Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45667 )
Change subject: sconfig: Move exported device names to separate output file ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/45667/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45667/1//COMMIT_MSG@14 PS1, Line 14: with only the FW_CONFIG_FIELD* macros, making it easily consumable by : payloads.
Shouldn't we also add FW_CONFIG_FIELD* macros to something like static_fw_config. […]
I like that, will try it.
https://review.coreboot.org/c/coreboot/+/45667/1/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/45667/1/Makefile.inc@622 PS1, Line 622: DEVICETREE_DEVICENAMES_H := $(obj)/static_devices.h : SCONFIG_OPTIONS += --output_d=$(DEVICETREE_DEVICENAMES_H)
Place this with DEVICETREE_STATIC_H above?
Ack
https://review.coreboot.org/c/coreboot/+/45667/1/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/45667/1/util/sconfig/main.c@1806 PS1, Line 1806: static_devices.h
Not a big problem, but we take in the file name as input which gets used to get a pointer to the fil […]
Good eye, I will change them to use the passed-in values
https://review.coreboot.org/c/coreboot/+/45667/1/util/sconfig/main.c@1826 PS1, Line 1826: fprintf(autohead, "\n#endif /* __STATIC_DEVICE_TREE_H */\n"); : fprintf(autodev, "\n#endif /* __STATIC_DEVICE_NAMES_H */\n");
Time to create helper functions to create each header file?
Good call, I was getting myself tripped up editing these...