Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44157 )
Change subject: mb/google/zork: SW changes for HP_INT_ODL in schematic v3.6 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/ramstage_common.c:
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... PS1, Line 7: #include <drivers/amd/i2s_machine_dev/chip.h> You will also need #include <drivers/i2c/generic/chip.h> for struct drivers_i2c_generic_config.
https://review.coreboot.org/c/coreboot/+/44157/1/src/mainboard/google/zork/v... PS1, Line 60: GPIO_62 Looks like GPIO_62 macro is not provided by SoC (probably because it is not a pad that can be configured as a normal GPIO). You might have to use 62 instead of GPIO_62 here.