Attention is currently required from: Kangheui Won, Tim Wawrzynczak, Reka Norman, Ivy Jian, Julius Werner.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63774 )
Change subject: lib/spd: Change log prefix for ddr4 params
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I agree with Tim, I'm not very familiar with this matter but it looks like you're taking the wrong a […]
I must admit I wasn't think this properly in CB:39366 , I don't know it will cause trouble back then. Let me explain the thoughts of this section. Back to 2020 when I refactor this code, we don't have DDR5/LPDDR5 SPD spec and still now. I don't use die and ASSERT and trying to use DDR4 parameter for the future generation memory. Because if it doesn't work, the MRC training will ASSERT or die. So I don't have to use die or ASSERT here. Thus, I think the warning level is legit here. Can you guys accept my explanation?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63774
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55f0968b78baaa2fc9a6bbebf6712fb8bfd349f6
Gerrit-Change-Number: 63774
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Kangheui Won
khwon@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Sat, 23 Apr 2022 21:09:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment