Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34686 )
Change subject: baytrail/rangeley: Update paths for FSP_FILE and VGA_BIOS_FILE ......................................................................
Patch Set 6:
(2 comments)
It's done
https://review.coreboot.org/c/coreboot/+/34686/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34686/5//COMMIT_MSG@7 PS5, Line 7: Update paths for FSP_FILE and VGA_BIOS_BIN
I don't see VGA_BIOS_BIN being changed, but rather VGA_BIOS_FILE. […]
Ack
https://review.coreboot.org/c/coreboot/+/34686/5/src/mainboard/adi/rcc-dff/K... File src/mainboard/adi/rcc-dff/Kconfig:
https://review.coreboot.org/c/coreboot/+/34686/5/src/mainboard/adi/rcc-dff/K... PS5, Line 39: config FSP_FILE
I would say the mainboard-specific Kconfig is now redundant, since it defines the same filepath as t […]
Acknowledged SoC-specific Kconfig: Removing default FSP_FILE might affect other mainboards. Mainboard-specific Kconfig: preferred the default parameter(FSP_FILE) from mainboard over the soc. Also, anyone can take up initiative to clean up things with the different commit, I am just keeping the change as it is for now.