EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39352 )
Change subject: lib/spd_bin: Extend LPDDR4 SPD information
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39352/4/src/lib/spd_bin.c
File src/lib/spd_bin.c:
PS4:
I think this file is getting messier with all the checks for each new DRAM type that we add support […]
Most of the attributes are extend and backward compatible. We can try this on DDR5 to see it has a lot different or not.
https://review.coreboot.org/c/coreboot/+/39352/4/src/lib/spd_bin.c@109
PS4, Line 109: is_memory_type_ddr4(dram_type) ? DDR4_ORGANIZATION
: : DDR3_ORGANIZATION;
This is not handled correctly for both LPDDR3 and LPDDR4.
I will add it :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39352
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68c9782c543afab4423296fa7ac1c078db5649c3
Gerrit-Change-Number: 39352
Gerrit-PatchSet: 4
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marco Chen
marcochen@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 07 Mar 2020 04:29:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment