Attention is currently required from: Angel Pons, Dinesh Gehlot, Subrata Banik.
Angel Pons has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/libgfxinit/+/82681?usp=email )
Change subject: gma: Add graphics id for tivviks ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/82681/comment/3e7e958a_905f2fc3?u... : PS2, Line 7: gma: Add graphics id for tivviks : : This patch includes the TWL graphics id for the Tivviks board. Since the IDs (plural: this change adds two IDs) are for TWL (which is used on the tivviks board), I would rephrase the commit message as follows:
gma: Add TWL graphics device IDs
Add the TWL graphics device IDs for the tivviks board.
File common/hw-gfx-gma-config.ads.template:
https://review.coreboot.org/c/libgfxinit/+/82681/comment/6f4fd277_ecb5111f?u... : PS2, Line 567: Device_Id = 16#46d3# or : Device_Id = 16#46d4# Provided that TWL *is* ADL-N, this is OK. If TWL needs to be handled differently, then these IDs should not be in here.