build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26467 )
Change subject: mainboard/amd/union_station: Fix coding style ......................................................................
Patch Set 2:
(11 comments)
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bios... File src/mainboard/amd/union_station/BiosCallOuts.c:
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bios... PS2, Line 24: VOID *ConfigPtr); need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bios... PS2, Line 157: Write64Mem8(GpioMmioAddr + SB_GPIO_REG21, Data8); // MXM_GPIO0. GPIO21 line over 80 characters
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bios... PS2, Line 163: Write64Mem8(GpioMmioAddr + SB_GPIO_REG21, Data8); // MXM_GPIO0. GPIO21 line over 80 characters
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bios... PS2, Line 173: Write64Mem8(GpioMmioAddr + SB_GPIO_REG25, Data8); // PCIE_RST#_LAN, GPIO25 line over 80 characters
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bios... PS2, Line 179: Write64Mem8(GpioMmioAddr + SB_GPIO_REG25, Data8); // PCIE_RST#_LAN, GPIO25 line over 80 characters
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bios... PS2, Line 189: Write64Mem8(GpioMmioAddr + SB_GPIO_REG02, Data8); // MPCIE_RST0, GPIO02 line over 80 characters
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/Bios... PS2, Line 195: Write64Mem8(GpioMmioAddr + SB_GPIO_REG02, Data8); // MPCIE_RST0, GPIO02 line over 80 characters
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/OemC... File src/mainboard/amd/union_station/OemCustomize.c:
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/OemC... PS2, Line 62: } Statements should start on a tabstop
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/OemC... PS2, Line 77: } Statements should start on a tabstop
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/mpta... File src/mainboard/amd/union_station/mptable.c:
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/mpta... PS2, Line 26: [0x00] = 0x10, 0x11, 0x12, 0x13, 0x14, 0x15, 0x16, 0x17, /* INTA# - INTH# */ line over 80 characters
https://review.coreboot.org/#/c/26467/2/src/mainboard/amd/union_station/mpta... PS2, Line 27: [0x08] = 0x00, 0x00, 0x00, 0x00, 0x1F, 0x1F, 0x1F, 0x1F, /* Misc-nil,0,1,2, INT from Serial irq */ line over 80 characters