13 Aug
2019
13 Aug
'19
1:28 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34854 )
Change subject: mainboard/google: Fix indirect includes ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34854/2/src/mainboard/intel/kunimit... File src/mainboard/intel/kunimitsu/smihandler.c:
https://review.coreboot.org/c/coreboot/+/34854/2/src/mainboard/intel/kunimit... PS2, Line 25: #include <intelblocks/smihandler.h> Bikeshedding grade: keep the includes sorted?
--
To view, visit https://review.coreboot.org/c/coreboot/+/34854
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie79702efab519b16cff45ccad61b95e7d8c2fbac
Gerrit-Change-Number: 34854
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 13 Aug 2019 11:28:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment