Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45643 )
Change subject: mb/google/volteer: Disable HybridStorageMode for Delbin ......................................................................
Patch Set 2:
Patch Set 2:
Patch Set 2:
How about we change the baseboard (which is the default) to be 0, and only enable the option in variants that require it?
Agreed. I had this patch before "https://review.coreboot.org/c/coreboot/+/44261". But then we decided to work on dynamically detecting optane just like FSP. On checking FSP code they are doing it through HECI messages. Do you suggest i fix that old patch by adding dynamic detection or its not worth adding that code for volteer?
I think for now we should do the following: 1) Set HybridStorageMode to 0 in the baseboard 2) Enable it in the devicetrees for boards that will potentially use it 3) If any shipping devices have SKUs that use optane and SKUs that don't, then we may want to consider dynamic detection SG?