Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31214 )
Change subject: mb/intel/coffeelake_rvp: Select CHROMEOS for CFL-U and WHL-U RVP
......................................................................
Patch Set 2: Code-Review+1
Is this just about the defaults
@Nico, its just about default selection. So we are good with this CL ?
Yap, looks good.
NB. I fear Jenkins doesn't build test w/o CHROMEOS if it
defaults to `y`. Need to investigate that further.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib61409402a948f8d5f91130e200c45320ea13d3d
Gerrit-Change-Number: 31214
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: PraveenX Hodagatta Pranesh
praveenx.hodagatta.pranesh@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 05 Feb 2019 22:34:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment