Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41639 )
Change subject: ec/google/chromeec/acpi/superio: Add PS/2 Mouse ACPI entry ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41639/1/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/41639/1/src/ec/google/chromeec/acpi... PS1, Line 176: IO (Decode16, 0x60, 0x60, 0x01, 0x01) : IO (Decode16, 0x64, 0x64, 0x01, 0x01) not sure if those should be added here again, since PS2K already uses those; ACPI might get unhappy about overlapping resources
https://review.coreboot.org/c/coreboot/+/41639/1/src/ec/google/chromeec/acpi... PS1, Line 184: } is it intended to not have a _PRS method here? the io resources are identical to the ones from PS2K, so they likely shouldn't be provided again, but the irq should be provided via _PRS