Attention is currently required from: Mike Banon, Marshall Dawson.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38313 )
Change subject: AGESA,binaryPI boards: Drop invalid MP table files
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
If the MPTABLEs for ASUS AM1I-A, A88XM-E and Lenovo G505S are to be removed (and no auto-generation […]
It would be great if you could document how to create a correct MP table for a given mainboard, and how to test it.
Another idea: AFAIUI, the interrupt mapping in the MP tables is the same as that in DSDT. Describe the mapping once, and derive the MP tables and DSDT ACPI code from that mapping. You would need to use acpigen. Ideally, mainboards would only define the interrupt mapping, and chipset or more generic code would generate both tables.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38313
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idd13b8b006fce7383f3f73c3c0a5d51a71c0155b
Gerrit-Change-Number: 38313
Gerrit-PatchSet: 6
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Mike Banon
mikebdp2@gmail.com
Gerrit-Comment-Date: Tue, 09 Mar 2021 12:32:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Mike Banon
mikebdp2@gmail.com
Gerrit-MessageType: comment