26 Apr
2023
26 Apr
'23
2:45 a.m.
Attention is currently required from: Sean Rhodes, Benjamin Doron, Angel Pons, Maximilian Brune.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )
Change subject: [RFC] drivers/option: Add option list in cbtable ......................................................................
Patch Set 2:
(1 comment)
File src/drivers/option/cfr.h:
https://review.coreboot.org/c/coreboot/+/74121/comment/e4cf45a5_3c315e51 PS2, Line 10: SETUP_MENU_VAR_FLAG_READONLY = 1 << 0, : SETUP_MENU_VAR_FLAG_GRAYOUT = 1 << 1, : SETUP_MENU_VAR_FLAG_SUPPRESS = 1 << 2,
Or shorten the prefix: CFR_OPTFLAG_
yeah this sounds better
--
To view, visit https://review.coreboot.org/c/coreboot/+/74121
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I304de7d26d79245a2e31a6d01f6c5643b31cb772
Gerrit-Change-Number: 74121
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Daniel Maslowski info@orangecms.org
Gerrit-CC: Lean Sheng Tan sheng.tan@9elements.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Benjamin Doron benjamin.doron00@gmail.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Comment-Date: Wed, 26 Apr 2023 09:45:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Rhodes sean@starlabs.systems
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment