Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31318 )
Change subject: soc/amd/common: Move PI refcode loader
......................................................................
Patch Set 3:
Patch Set 3:
Not sure why you want to move code from a already existing file into a new file? Are you planning on doing this unification? What about future Agesa version 9 (currently being developed)? Should we force Agesa 9 to use this loaders? I would rather wait Martin's opinion.
You cannot talk to me about AGESAv9. Not my choice, I would like it if you could.
From I understood AGESAv9 is such a different beast that code-sharing with AGESAv8 in coreboot proper would not make sense. And for god's sake let's finally drop agesawrapper.c!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31318
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I68885e7f855b195c178e746c8f3f0f49166d0def
Gerrit-Change-Number: 31318
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 11 Feb 2019 19:32:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment