Attention is currently required from: Wonkyu Kim, Paul Menzel. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63615 )
Change subject: intel/common/../systemagent: Enable MCHBAR in bootblock ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63615/comment/0bb5f591_d20ea341 PS4, Line 10: As there is no harm to enable : MCHBAR from bootblock even in existing plaforms
So the benefit is code unification? To my understanding the bootblock really should be as small as p […]
Enabling MCHBAR takes a PCI config register write or two, so size isn't a concern. The main reason is that the GPMR driver needs to access MCHBAR registers in bootblock code.
https://review.coreboot.org/c/coreboot/+/63615/comment/1590673a_5b2429a2 PS4, Line 13:
Don’t you need to remove also code from the other platforms doing this in romstage?
Yes, I'd consider removing the code enabling MCHBAR in romstage.