Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44480 )
Change subject: mb/google/zork: Switch zork to use spd_tools
......................................................................
Patch Set 15:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44480/15//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44480/15//COMMIT_MSG@19
PS15, Line 19: go build gen_part_id.go
: for variant in "trembyle" "ezkinil" "dalboz" "dirinboz" "berknip" "morphius" "woomax" "vilboz"; do
: ./gen_part_id ../../../src/mainboard/google/zork/spd ../../../src/mainboard/google/zork/variants/${variant}/spd/ ../../../src/mainboard/google/zork/variants/${variant}/spd/mem_parts_used.txt
: done
Can this be done as part of the build so we don't need to check in the generated artifacts? This wou […]
Is golang supported in the build?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44480
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0553858f83d3d1e90cf35bece108768f004a29a5
Gerrit-Change-Number: 44480
Gerrit-PatchSet: 15
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Thu, 27 Aug 2020 21:58:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment