Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45078 )
Change subject: soc/intel/elkhartlake: Update Kconfig
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45078/4//COMMIT_MSG@17
PS4, Line 17: 8. update UART base address
Thanks for your feedback, i understand your concern, but this is only 1 line change for each of them […]
Since there is for now no mainboard that uses this code it is not buildable yet. I guess in this case there is no such strict demand to have 8 commits just for this change. I would like to get that in so that we can eventually get the mainboard code merged, which in turn will finally enable this code to be build-tested at all.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45078
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a44d357d71be706f402a6b2a4f2d4e7c0eeb4a9
Gerrit-Change-Number: 45078
Gerrit-PatchSet: 5
Gerrit-Owner: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 02 Dec 2020 05:29:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Lean Sheng Tan
lean.sheng.tan@intel.com
Gerrit-MessageType: comment