[coreboot-gerrit] Change in coreboot[master]: cbfs: Enable CBFS mcache on most chipsets

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38424 )

Change subject: cbfs: Enable CBFS mcache on most chipsets
......................................................................

Patch Set 18:

(2 comments)

https://review.coreboot.org/c/coreboot/+/38424/10/src/arch/x86/car.ld 
File src/arch/x86/car.ld:

https://review.coreboot.org/c/coreboot/+/38424/10/src/arch/x86/car.ld@50 
PS10, Line 50: #if !CONFIG(NO_CBFS_MCACHE)
             : 	CBFS_MCACHE(., CONFIG_CBFS_MCACHE_SIZE)
             : #endif
> I definitely want it to work, because it will be required for the verification stuff I want to imple […]

Ack

https://review.coreboot.org/c/coreboot/+/38424/17/src/soc/amd/picasso/memlay... 
File src/soc/amd/picasso/memlayout_x86.ld:

https://review.coreboot.org/c/coreboot/+/38424/17/src/soc/amd/picasso/memlay... 
PS17, Line 88: 	CBFS_MCACHE(., CONFIG_CBFS_MCACHE_SIZE)
> i386-elf-ld.bfd: cbfs_mcache must be aligned to 4! […]

I've copied in the one ALIGN_COUNTER(64) from the PSP memlayout that prevents this issue now, I'll leave it to Martin to clean up the whole thing later as he sees fit.