build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25082 )
Change subject: drivers/spi: Read Winbond's flash protection bits ......................................................................
Patch Set 13:
(9 comments)
https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c:
https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@52 PS13, Line 52: uint8_t *const prot; "foo *const bar" should be "foo *const bar"
https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@132 PS13, Line 132: .prot = (u8[6]){ space required before the open brace '{'
https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@150 PS13, Line 150: .prot = (u8[7]){ space required before the open brace '{'
https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@169 PS13, Line 169: .prot = (u8[7]){ space required before the open brace '{'
https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@188 PS13, Line 188: .prot = (u8[7]){ space required before the open brace '{'
https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@207 PS13, Line 207: .prot = (u8[7]){ space required before the open brace '{'
https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@226 PS13, Line 226: .prot = (u8[7]){ space required before the open brace '{'
https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@245 PS13, Line 245: .prot = (u8[7]){ space required before the open brace '{'
https://review.coreboot.org/#/c/25082/13/src/drivers/spi/winbond.c@264 PS13, Line 264: .prot = (u8[10]){ space required before the open brace '{'