Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Kilari Raasi, Nick Vaccaro, Paul Menzel, Subrata Banik.
Kilari Raasi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81446?usp=email )
Change subject: intel/alderlake: Remove FSP_PUBLISH_MBP_HOB config for RPL
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81446/comment/b37a091c_42f93104 :
PS1, Line 11:
Why was it added in the first place, and why can it be removed now?
Updated commit message with details.
Commit Message:
https://review.coreboot.org/c/coreboot/+/81446/comment/7bcbddc8_66f5f48b :
PS2, Line 8:
: By removing FSP_PUBLISH_MBP_HOB for RPL SkipMbpHob is set to 0.
: And it prevents the boot time increase of ~158ms.
i guess you are presenting the twisted fact here, ideally we wish to avoid sending MBP cmd and creat […]
Done
https://review.coreboot.org/c/coreboot/+/81446/comment/a5e260fe_80456275 :
PS2, Line 18: With
without
Acknowledged
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/81446/comment/d52b5098_8dcd78b3 :
PS2, Line 529: RPL
consider changing this now?
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81446?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8a99a57b644732074e41051d99e63576f1edd229
Gerrit-Change-Number: 81446
Gerrit-PatchSet: 3
Gerrit-Owner: Kilari Raasi
kilari.raasi@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kilari Raasi
kilari.raasi@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kilari Raasi
kilari.raasi@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 28 Mar 2024 05:01:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment