[coreboot-gerrit] [M] Change in coreboot[main]: amdfwtool: Move the address of tables to the context

[Felix Held (Code Review)]

Attention is currently required from: Bao Zheng, Fred Reitberger, Zheng Bao.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81225?usp=email )

Change subject: amdfwtool: Move the address of tables to the context
......................................................................

Patch Set 3: Code-Review+1

(1 comment)

File util/amdfwtool/amdfwtool.c:

https://review.coreboot.org/c/coreboot/+/81225/comment/af0e2e5a_63167f20 :
PS3, Line 1640: ctx.pspdir = NULL;
              : 			ctx.pspdir2 = NULL;
              : 			ctx.pspdir2_b = NULL;
              : 			ctx.biosdir = NULL;
              : 			ctx.biosdir2 = NULL;
              : 			ctx.biosdir2_b = NULL;
              : 			ctx.ish_a_dir = NULL;
              : 			ctx.ish_b_dir = NULL;
i'd move those directly before the if (cb_config.use_combo && combo_index > 0). in the first iteration of the do while loop, those are already NULL due to the context ctx = { 0 };, but at least for me it would make the code a bit easier to read if resetting those to NULL wouldn't be conditional on this not being the first iteration of the do while loop