3 Jan
2020
3 Jan
'20
7:24 a.m.
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37738 )
Change subject: southbridge/amd: deduplicate MMIO macro [WIP] ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37738/1/src/mainboard/asus/f2a85-m/... File src/mainboard/asus/f2a85-m/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37738/1/src/mainboard/asus/f2a85-m/... PS1, Line 35: SB_MMIO_MISC32(0x28) = reg32;
Right. The macro indeed seems to be a candidate for removal. […]
Ack
--
To view, visit https://review.coreboot.org/c/coreboot/+/37738
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I583034ef0b0ed3e5a5e3dd680c57728ec5efbc8f
Gerrit-Change-Number: 37738
Gerrit-PatchSet: 2
Gerrit-Owner: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Rudolf Marek r.marek@assembler.cz
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Fri, 03 Jan 2020 14:24:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki kyosti.malkki@gmail.com
Comment-In-Reply-To: Idwer Vollering vidwer@gmail.com
Gerrit-MessageType: comment