Attention is currently required from: Furquan Shaikh, Prasad Malisetty.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58683 )
Change subject: DO NOT SUBMIT: Proposed libpayload changes for PCI mmio ops support
......................................................................
Patch Set 2:
(2 comments)
File src/lib/coreboot_table.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131776):
https://review.coreboot.org/c/coreboot/+/58683/comment/d16cbf8b_42eae66d
PS2, Line 502: (CONFIG_MMIO_LENGTH > 0))
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131776):
https://review.coreboot.org/c/coreboot/+/58683/comment/cf300f10_47c20c3c
PS2, Line 502: (CONFIG_MMIO_LENGTH > 0))
please, no spaces at the start of a line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic2799b35fb0c348896c078ff5356052fc85e05eb
Gerrit-Change-Number: 58683
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Prasad Malisetty
pmaliset@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Fri, 29 Oct 2021 08:23:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment