Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45052 )
Change subject: soc/intel/tigerlake: Add Acoustic features
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45052/8/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/45052/8/src/soc/intel/tigerlake/fsp...
PS8, Line 260: for (i = 0; i < ARRAY_SIZE(config->SlowSlewRate); i++)
Why not do this as a single memcpy using ARRAY_SIZE * sizeof array element?
https://review.coreboot.org/c/coreboot/+/45052/8/src/soc/intel/tigerlake/fsp...
PS8, Line 264: for (i = 0; i < ARRAY_SIZE(config->FastPkgCRampDisable); i++)
Why not do this as a single memcpy using ARRAY_SIZE * sizeof array element?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45052
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1924a3bac8beb16a9d841891696f9a3dea0d425f
Gerrit-Change-Number: 45052
Gerrit-PatchSet: 8
Gerrit-Owner: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Eric Herrmann
eherrmann@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nick Vaccaro
nvaccaro@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Oct 2020 16:48:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment