16 Sep
2020
16 Sep
'20
10:55 p.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44265 )
Change subject: ec/google/chromeec: Add dptc interface support ......................................................................
Patch Set 17: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44265/16/src/ec/google/chromeec/acp... File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/c/coreboot/+/44265/16/src/ec/google/chromeec/acp... PS16, Line 386: DPTC_SUPPORT_ENABLE
nit: I think we should name this something like EC_ENABLE_AMD_DPTC_SUPPORT just to make it clear wha […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/44265
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2be7942132cea474237f531021ad4fd9856b5050
Gerrit-Change-Number: 44265
Gerrit-PatchSet: 17
Gerrit-Owner: chris wang Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Aaron Durbin adurbin@chromium.org
Gerrit-CC: Keith Tzeng keith.tzeng@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Sep 2020 05:55:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Gerrit-MessageType: comment