Attention is currently required from: Angel Pons.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70919 )
Change subject: mb/google/poppy: Implement touchscreen,digitizer power sequencing ......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/c/coreboot/+/70919/comment/4eb7aae3_15b4e67e PS3, Line 223: PAD_CFG_TERM_GPO(GPP_E11, 1, DN_20K, DEEP),
How does a GPO with termination work, exactly? This also causes contention in the internal PD resist […]
fixed at start of patch train per discussion in IRC
https://review.coreboot.org/c/coreboot/+/70919/comment/e1c402fd_478fa42f PS3, Line 388: PAD_CFG_TERM_GPO(GPP_E11, 0, DN_20K, DEEP),
Ditto, even if there's no contention.
fixed at start of patch train per discussion in IRC