Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46373 )
Change subject: haswell/broadwell: Fix `BLCK` typo
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46373/2/src/cpu/intel/haswell/haswe...
File src/cpu/intel/haswell/haswell_init.c:
https://review.coreboot.org/c/coreboot/+/46373/2/src/cpu/intel/haswell/haswe...
PS2, Line 211: * the 100MHz BCLCK against the 24MHz BCLK to restore the clocks properly
Ugh, sorry, I thought this would be a quick review. But I don't understand […]
Ok, they call them both BCLK. But that also includes that `BCLCK`. Please
fix that too.
If you want, you can also align the /* style with our guidelines.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46373
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifed3c8250d5c9869493285d0b87580b70ff37965
Gerrit-Change-Number: 46373
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 17 Oct 2020 13:53:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
